]> git.baikalelectronics.ru Git - kernel.git/commit
net: cleanup gfp mask in alloc_skb_with_frags
authorMichal Hocko <mhocko@suse.com>
Thu, 28 Jun 2018 15:53:06 +0000 (17:53 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 30 Jun 2018 11:18:49 +0000 (20:18 +0900)
commit9c97601d632b73a2edbb8b32630c20d92f5bded9
tree710920f42f63c6149ffa9a0bf28627d3f9babd0d
parent74db4adfbd88fae91a721880693d06f06e42ba4d
net: cleanup gfp mask in alloc_skb_with_frags

alloc_skb_with_frags uses __GFP_NORETRY for non-sleeping allocations
which is just a noop and a little bit confusing.

__GFP_NORETRY was added by cb47d1242795 ("net: use __GFP_NORETRY for
high order allocations") to prevent from the OOM killer. Yet this was
not enough because 8ee4134acfd0 ("net: don't wait for order-3 page
allocation") didn't want an excessive reclaim for non-costly orders
so it made it completely NOWAIT while it preserved __GFP_NORETRY in
place which is now redundant.

Drop the pointless __GFP_NORETRY because this function is used as
copy&paste source for other places.

Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/skbuff.c