]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: qla2xxx: Format log strings only if needed
authorRoman Bolshakov <r.bolshakov@yadro.com>
Fri, 12 Nov 2021 14:54:46 +0000 (17:54 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 7 Dec 2021 03:38:17 +0000 (22:38 -0500)
commit9c6bc4610fe2bf7f7a6172e3a7ed22a55866d4d8
treefb2aa5b48d7240ec362359d5fcf823aced55b540
parent29dbc86d43b005fae8dfb990239e713c811d1b89
scsi: qla2xxx: Format log strings only if needed

Commit e102d5281311 ("scsi: qla2xxx: add ring buffer for tracing debug
logs") introduced unconditional log string formatting to ql_dbg() even if
ql_dbg_log event is disabled. It harms performance because some strings are
formatted in fastpath and/or interrupt context.

Link: https://lore.kernel.org/r/20211112145446.51210-1-r.bolshakov@yadro.com
Fixes: e102d5281311 ("scsi: qla2xxx: add ring buffer for tracing debug logs")
Cc: Rajan Shanmugavelu <rajan.shanmugavelu@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_dbg.c