]> git.baikalelectronics.ru Git - kernel.git/commit
nfc: nci: Potential off by one in ->pipes[] array
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 3 Apr 2019 07:13:51 +0000 (10:13 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 6 Apr 2019 22:05:07 +0000 (15:05 -0700)
commit9b09ab7cff47850391517ac1c9097eabc896f6f3
tree808896ceb6b2639bf7d00c8d086000b13abefabd
parent09d015fa849e214b0f6208043285a0792d912bcb
nfc: nci: Potential off by one in ->pipes[] array

This is similar to commit ba60d3ba0955 ("NFC: Fix the number of pipes")
where we changed NFC_HCI_MAX_PIPES from 127 to 128.

As the comment next to the define explains, the pipe identifier is 7
bits long.  The highest possible pipe is 127, but the number of possible
pipes is 128.  As the code is now, then there is potential for an
out of bounds array access:

    net/nfc/nci/hci.c:297 nci_hci_cmd_received() warn: array off by one?
    'ndev->hci_dev->pipes[pipe]' '0-127 == 127'

Fixes: 7bc4a77f0fb1 ("NFC: nci: Add HCI over NCI protocol support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/nfc/nci_core.h