]> git.baikalelectronics.ru Git - kernel.git/commit
ARM: dts: ls1021a: Restore MDIO compatible to gianfar
authorVladimir Oltean <olteanv@gmail.com>
Sun, 26 Jan 2020 19:49:50 +0000 (21:49 +0200)
committerShawn Guo <shawnguo@kernel.org>
Fri, 14 Feb 2020 02:34:27 +0000 (10:34 +0800)
commit9afffa41f9113f69679ceab45feadccf462f737d
tree25bf51275e36312289926cc326d8e4e399c6b92a
parentf9df96452422a4ce1dba293a0afaa3b04bf96b53
ARM: dts: ls1021a: Restore MDIO compatible to gianfar

The difference between "fsl,etsec2-mdio" and "gianfar" has to do with
the .get_tbipa function, which calculates the address of the TBIPA
register automatically, if not explicitly specified. [ see
drivers/net/ethernet/freescale/fsl_pq_mdio.c ]. On LS1021A, the TBIPA
register is at offset 0x30 within the port register block, which is what
the "gianfar" method of calculating addresses actually does.

Luckily, the bad "compatible" is inconsequential for ls1021a.dtsi,
because the TBIPA register is explicitly specified via the second "reg"
(<0x0 0x2d10030 0x0 0x4>), so the "get_tbipa" function is dead code.
Nonetheless it's good to restore it to its correct value.

Background discussion:
https://www.spinics.net/lists/stable/msg361156.html

Fixes: f81a926f7d6d ("ARM: dts: ls1021: Fix SGMII PCS link remaining down after PHY disconnect")
Reported-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
arch/arm/boot/dts/ls1021a.dtsi