]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "ALSA: gus: add a check of the status of snd_ctl_add"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:56:59 +0000 (13:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 15:33:45 +0000 (17:33 +0200)
commit9a9bc51c893f9d1c681dd9bede59347768a4e7b2
tree0cae017debd11cd7fc6f116b70449d0fae112ceb
parent24f54abf82b3a52c558c1b4aeaed6ca42549ba02
Revert "ALSA: gus: add a check of the status of snd_ctl_add"

This reverts commit f91a9f96006a0c9e76478616903425180cd4799a.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original commit did nothing if there was an error, except to print
out a message, which is pointless.  So remove the commit as it gives a
"false sense of doing something".

Cc: Kangjie Lu <kjlu@umn.edu>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20210503115736.2104747-33-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/isa/gus/gus_main.c