]> git.baikalelectronics.ru Git - kernel.git/commit
perf probe: Clean up probe_point_lazy_walker() return value
authorIngo Molnar <mingo@elte.hu>
Tue, 15 Mar 2011 19:51:09 +0000 (20:51 +0100)
committerIngo Molnar <mingo@elte.hu>
Tue, 15 Mar 2011 19:51:09 +0000 (20:51 +0100)
commit9a7c69d13084d4b15d766f4b06dbd5a80733a1bd
treee06a7c18e840745869ffa72d568d4c125c7e3fb4
parentc1ce1ae6763a2db3b53031dfe4e035a5a3737aed
perf probe: Clean up probe_point_lazy_walker() return value

Newer compilers (gcc 4.6) complains about:

        return ret < 0 ?: 0;

For the following reason:

  util/probe-finder.c: In function ‘probe_point_lazy_walker’:
  util/probe-finder.c:1331:18: error: the omitted middle operand in ?: will always be ‘true’, suggest explicit middle operand [-Werror=parentheses]

And indeed the return value is a somewhat obscure (but correct) value
of 'true', so return 'ret' instead - this is cleaner and unconfuses
GCC as well.

Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
tools/perf/util/probe-finder.c