]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: moxart: remove unneeded check for drvdata
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 23 Sep 2020 15:37:38 +0000 (17:37 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 25 Sep 2020 11:24:02 +0000 (13:24 +0200)
commit9a6df61ded072fc79b5658838cb2fa21e8a40d87
treebda7d244f3948f53c2691072ed294dd75f038d4e
parent219d75e5e75ead96d5555d85f5f31c43559aeb01
mmc: moxart: remove unneeded check for drvdata

The 'struct mmc_host *mmc' comes from drvdata set at the end of probe,
so it cannot be NULL.  The code already dereferences it few lines before
the check with mmc_priv().  This also fixes smatch warning:

  drivers/mmc/host/moxart-mmc.c:692 moxart_remove() warn: variable dereferenced before check 'mmc' (see line 688)

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200923153739.30327-1-krzk@kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/moxart-mmc.c