]> git.baikalelectronics.ru Git - kernel.git/commit
brcmfmac: fix memory leakage in msgbuf
authorArend van Spriel <arend@broadcom.com>
Thu, 7 Aug 2014 12:45:09 +0000 (14:45 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 11 Aug 2014 18:43:51 +0000 (14:43 -0400)
commit9a40526921d1e2d37aa8b657eb12ced22f0353b1
tree360d48be9352651dac43b86526e5c3a6c7325390
parent05dda0cb29fbb155fc65e50737e1f780ea5c8b30
brcmfmac: fix memory leakage in msgbuf

The kbuild robot came up with the following warning:

tree:   .../kernel/git/linville/wireless-next.git master
head:   f79055d98c7246b67eeb02c0fe81dd9ba02fb46d
commit: 985833de382d770edb6e7430644e0c7bfd3750b7
 [5/13] brcmfmac: Adding msgbuf protocol.

coccinelle warnings:
 drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c:1309:1-28:
   alloc with no test, possible model on line 1318

Looking into the issue, it turned out that the referred allocation
buffer was not being released in failure path nor upon module
unload.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Daniel (Deognyoun) Kim <dekim@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c