]> git.baikalelectronics.ru Git - kernel.git/commit
regulator: core: Fix enable_count imbalance with EXCLUSIVE_GET
authorZev Weiss <zev@bewilderbeest.net>
Thu, 5 May 2022 04:31:52 +0000 (21:31 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:22:54 +0000 (10:22 +0200)
commit9a3499ccbcbc33410f691ecc07ca2c09fb343f52
tree482d5cf5d15949a90cce5949b6b422733ecf57af
parented3a92593ccf410283cc5c46f6b93904ba6c1803
regulator: core: Fix enable_count imbalance with EXCLUSIVE_GET

[ Upstream commit e4907a9f286193ea5dd7bfb9183940c0eaa7279b ]

Since the introduction of regulator->enable_count, a driver that did
an exclusive get on an already-enabled regulator would end up with
enable_count initialized to 0 but rdev->use_count initialized to 1.
With that starting point the regulator is effectively stuck enabled,
because if the driver attempted to disable it it would fail the
enable_count underflow check in _regulator_handle_consumer_disable().

The EXCLUSIVE_GET path in _regulator_get() now initializes
enable_count along with rdev->use_count so that the regulator can be
disabled without underflowing the former.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Fixes: 0a7ba1ffa5056 ("regulator: core: Only count load for enabled consumers")
Link: https://lore.kernel.org/r/20220505043152.12933-1-zev@bewilderbeest.net
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/core.c