]> git.baikalelectronics.ru Git - kernel.git/commit
drm/mediatek: Clean dangling pointer on bind error path
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Tue, 22 Nov 2022 14:39:49 +0000 (09:39 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:33:17 +0000 (09:33 +0100)
commit996bd2e67e78225a6f310016b1ee34f18da91595
treed53a97c8636fe9ebc7b8d6496cc425b51c5e8078
parente46caa11d0e934d1e770c8ef80fd691acfdf8ed4
drm/mediatek: Clean dangling pointer on bind error path

[ Upstream commit 29d310f4265ade377e5e81a00bca236e4ff7a07d ]

mtk_drm_bind() can fail, in which case drm_dev_put() is called,
destroying the drm_device object. However a pointer to it was still
being held in the private object, and that pointer would be passed along
to DRM in mtk_drm_sys_prepare() if a suspend were triggered at that
point, resulting in a panic. Clean the pointer when destroying the
object in the error path to prevent this from happening.

Fixes: 6a252d99de5c ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patchwork.kernel.org/project/linux-mediatek/patch/20221122143949.3493104-1-nfraprado@collabora.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/mediatek/mtk_drm_drv.c