]> git.baikalelectronics.ru Git - kernel.git/commit
[media] mxl111sf: reduce stack usage in init function
authorArnd Bergmann <arnd@arndb.de>
Thu, 2 Feb 2017 14:53:07 +0000 (12:53 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 3 Mar 2017 10:21:48 +0000 (07:21 -0300)
commit995791827bd41da7fe6a4eea69de22ad2f582e3c
tree9bbd46210f7c48ef8e64d88cd9a2979a446feda5
parent6e1b8a4221e752b15c6a7adabe15e29adbe632bf
[media] mxl111sf: reduce stack usage in init function

mxl111sf uses a lot of kernel stack memory as it puts an i2c_client
structure on the stack:

drivers/media/usb/dvb-usb-v2/mxl111sf.c: In function 'mxl111sf_init':
drivers/media/usb/dvb-usb-v2/mxl111sf.c:953:1: error: the frame size of 1248 bytes is larger than 1152 bytes [-Werror=frame-larger-than=]

We can avoid doing this by open-coding the call to i2c_transfer()
instead of calling tveeprom_read(), and not passing an i2c_client
pointer to tveeprom_hauppauge_analog(), which would ignore that
anyway.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/dvb-usb-v2/mxl111sf.c