]> git.baikalelectronics.ru Git - kernel.git/commit
[PATCH] blk: no memory barrier
authorNick Piggin <nickpiggin@yahoo.com.au>
Thu, 23 Jun 2005 07:08:52 +0000 (00:08 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Thu, 23 Jun 2005 16:45:16 +0000 (09:45 -0700)
commit9919dc32ad80210906203e2c9878c4556ef78037
treeda9f94abed8dac7479507601694d9276b2dbaf28
parent75c4cb459f973724626b1a6400599f5893497bd1
[PATCH] blk: no memory barrier

This memory barrier is not needed because the waitqueue will only get waiters
on it in the following situations:

rq->count has exceeded the threshold - however all manipulations of ->count
are performed under the runqueue lock, and so we will correctly pick up any
waiter.

Memory allocation for the request fails.  In this case, there is no additional
help provided by the memory barrier.  We are guaranteed to eventually wake up
waiters because the request allocation mempool guarantees that if the mem
allocation for a request fails, there must be some requests in flight.  They
will wake up waiters when they are retired.

Signed-off-by: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Jens Axboe <axboe@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/block/ll_rw_blk.c