]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: don't ever return a stale pointer from __xfs_dir3_free_read
authorDarrick J. Wong <darrick.wong@oracle.com>
Wed, 11 Mar 2020 17:37:55 +0000 (10:37 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Thu, 12 Mar 2020 14:58:12 +0000 (07:58 -0700)
commit989171fc76a7b25a8dcd92bcda2c4bc41be89959
tree1aedd326cf8622355aa36131cd29f048f68003f0
parent685f9c29a662747addb45a4bef1afd0f310afe54
xfs: don't ever return a stale pointer from __xfs_dir3_free_read

If we decide that a directory free block is corrupt, we must take care
not to leak a buffer pointer to the caller.  After xfs_trans_brelse
returns, the buffer can be freed or reused, which means that we have to
set *bpp back to NULL.

Callers are supposed to notice the nonzero return value and not use the
buffer pointer, but we should code more defensively, even if all current
callers handle this situation correctly.

Fixes: 371f950d2823 ("xfs: verify free block header fields")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
fs/xfs/libxfs/xfs_dir2_node.c