]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: rt5682: do not block workqueue if card is unbound
authorKai Vehmanen <kai.vehmanen@linux.intel.com>
Mon, 7 Feb 2022 15:30:00 +0000 (17:30 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 8 Feb 2022 13:37:46 +0000 (13:37 +0000)
commit988ae7dfd5f1fa9f8978ef501d022fdd60c70684
tree93344473081c991e35e8ec98214cb8e5de090226
parent9ae99e4412e6d7335d1582c351db78dc3ef3e007
ASoC: rt5682: do not block workqueue if card is unbound

The current rt5682_jack_detect_handler() assumes the component
and card will always show up and implements an infinite usleep
loop waiting for them to show up.

This does not hold true if a codec interrupt (or other
event) occurs when the card is unbound. The codec driver's
remove  or shutdown functions cannot cancel the workqueue due
to the wait loop. As a result, code can either end up blocking
the workqueue, or hit a kernel oops when the card is freed.

Fix the issue by rescheduling the jack detect handler in
case the card is not ready. In case card never shows up,
the shutdown/remove/suspend calls can now cancel the detect
task.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Shuming Fan <shumingf@realtek.com>
Link: https://lore.kernel.org/r/20220207153000.3452802-3-kai.vehmanen@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5682.c