]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/pseries: hcall_exit tracepoint retval should be signed
authorMichael Ellerman <mpe@ellerman.id.au>
Mon, 7 May 2018 13:03:55 +0000 (23:03 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 10 May 2018 13:17:43 +0000 (23:17 +1000)
commit9861aac384ce708eb8b2a60b2c61735fd3d1fa39
tree017f3ee3244ef4d37f248aa4957debb602844e48
parentde22875e83dc887a964be63fdcf46be802696add
powerpc/pseries: hcall_exit tracepoint retval should be signed

The hcall_exit() tracepoint has retval defined as unsigned long. That
leads to humours results like:

  bash-3686  [009] d..2   854.134094: hcall_entry: opcode=24
  bash-3686  [009] d..2   854.134095: hcall_exit: opcode=24 retval=18446744073709551609

It's normal for some hcalls to return negative values, displaying them
as unsigned isn't very helpful. So change it to signed.

  bash-3711  [001] d..2   471.691008: hcall_entry: opcode=24
  bash-3711  [001] d..2   471.691008: hcall_exit: opcode=24 retval=-7

Which can be more easily compared to H_NOT_FOUND in hvcall.h

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Tested-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
arch/powerpc/include/asm/asm-prototypes.h
arch/powerpc/include/asm/trace.h
arch/powerpc/platforms/pseries/hvCall_inst.c
arch/powerpc/platforms/pseries/lpar.c