]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: SOF: Fix NULL pointer exception in sof_pci_probe callback
authorAjit Kumar Pandey <AjitKumar.Pandey@amd.com>
Tue, 26 Apr 2022 18:33:57 +0000 (13:33 -0500)
committerMark Brown <broonie@kernel.org>
Wed, 27 Apr 2022 13:15:21 +0000 (14:15 +0100)
commit9841b0860ebd8ef8f67ef39d1916a6e95377d962
treea9da2f439b906e63622ba504059eea688adb4ba2
parent3714d770506d88511f6a54c7b21b771436b61edc
ASoC: SOF: Fix NULL pointer exception in sof_pci_probe callback

We are accessing "desc->ops" in sof_pci_probe without checking "desc"
pointer. This results in NULL pointer exception if pci_id->driver_data
i.e desc pointer isn't defined in sof device probe:

BUG: kernel NULL pointer dereference, address: 0000000000000060
PGD 0 P4D 0
Oops: 0000 [#1] PREEMPT SMP NOPTI
RIP: 0010:sof_pci_probe+0x1e/0x17f [snd_sof_pci]
Code: Unable to access opcode bytes at RIP 0xffffffffc043dff4.
RSP: 0018:ffffac4b03b9b8d8 EFLAGS: 00010246

Add NULL pointer check for sof_dev_desc pointer to avoid such exception.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220426183357.102155-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/sof-pci-dev.c