]> git.baikalelectronics.ru Git - kernel.git/commit
iwlwifi: mvm: only send LEDS_CMD when the FW supports it
authorLuca Coelho <luciano.coelho@intel.com>
Thu, 7 Sep 2017 07:51:52 +0000 (10:51 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 7 Sep 2017 16:40:09 +0000 (19:40 +0300)
commit98414309fee39394f304b2b55e3ac65dc603ff70
treeb7e5fdac3ed1de23e16970889bed4d719127ca38
parent4985523ded7c17a9c558c89729c212172cd5634d
iwlwifi: mvm: only send LEDS_CMD when the FW supports it

The LEDS_CMD command is only supported in some newer FW versions
(e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions
(such as iwlwifi-8000C-27.ucode).

To fix this, check for a new bit in the FW capabilities TLV that tells
when the command is supported.

Note that the current version of -31.ucode in linux-firmware.git
(31.532993.0) does not have this capability bit set, so the LED won't
work, even though this version should support it.  But we will update
this firmware soon, so it won't be a problem anymore.

Fixes: f71a7a073923 ("iwlwifi: mvm: use firmware LED command where applicable")
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/intel/iwlwifi/fw/file.h
drivers/net/wireless/intel/iwlwifi/mvm/led.c