]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/perf: Dereference BHRB entries safely
authorRavi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Tue, 12 Dec 2017 12:29:15 +0000 (17:59 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 13 Dec 2017 09:29:20 +0000 (20:29 +1100)
commit96faf50c5522d64de904b979e4de9525a44b8c7f
tree95b36051d7985122edfb27e0234fc57834c2ad25
parente861c2a7deddeefbc0f46aa3e9c303d1cfd49093
powerpc/perf: Dereference BHRB entries safely

It's theoretically possible that branch instructions recorded in
BHRB (Branch History Rolling Buffer) entries have already been
unmapped before they are processed by the kernel. Hence, trying to
dereference such memory location will result in a crash. eg:

    Unable to handle kernel paging request for data at address 0xd000000019c41764
    Faulting instruction address: 0xc000000000084a14
    NIP [c000000000084a14] branch_target+0x4/0x70
    LR [c0000000000eb828] record_and_restart+0x568/0x5c0
    Call Trace:
    [c0000000000eb3b4] record_and_restart+0xf4/0x5c0 (unreliable)
    [c0000000000ec378] perf_event_interrupt+0x298/0x460
    [c000000000027964] performance_monitor_exception+0x54/0x70
    [c000000000009ba4] performance_monitor_common+0x114/0x120

Fix it by deferefencing the addresses safely.

Fixes: 711702f72ea4 ("powerpc/perf: Fix setting of "to" addresses for BHRB")
Cc: stable@vger.kernel.org # v3.10+
Suggested-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Reviewed-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
[mpe: Use probe_kernel_read() which is clearer, tweak change log]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/perf/core-book3s.c