]> git.baikalelectronics.ru Git - kernel.git/commit
iio: light: tcs3472: do not free unallocated IRQ
authorfrank zago <frank@zago.net>
Tue, 27 Apr 2021 02:20:17 +0000 (21:20 -0500)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 16 Jun 2021 13:57:03 +0000 (14:57 +0100)
commit96d97634a1a23a6c21c97516398f7185e2f79ae5
treef9fd9742c3a489a1f16c95273aa276353f01623f
parent97698b5d92db453856a96719454d72afba151265
iio: light: tcs3472: do not free unallocated IRQ

Allocating an IRQ is conditional to the IRQ existence, but freeing it
was not. If no IRQ was allocate, the driver would still try to free
IRQ 0. Add the missing checks.

This fixes the following trace when the driver is removed:

[  100.667788] Trying to free already-free IRQ 0
[  100.667793] WARNING: CPU: 0 PID: 2315 at kernel/irq/manage.c:1826 free_irq+0x1fd/0x370
...
[  100.667914] Call Trace:
[  100.667920]  tcs3472_remove+0x3a/0x90 [tcs3472]
[  100.667927]  i2c_device_remove+0x2b/0xa0

Signed-off-by: frank zago <frank@zago.net>
Link: https://lore.kernel.org/r/20210427022017.19314-2-frank@zago.net
Fixes: f1236620ab88 ("iio: light: tcs3472: support out-of-threshold events")
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/light/tcs3472.c