]> git.baikalelectronics.ru Git - kernel.git/commit
hwmon: (adt7475) Potential error pointer dereferences
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 14 Aug 2018 09:12:36 +0000 (12:12 +0300)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 27 Aug 2018 00:45:25 +0000 (17:45 -0700)
commit96747c5163820c5c8cf980523abe838248d5adf6
treeb3009695670dbd78f3d4ef432cab619f6604d78e
parent68141eb4dadb520495bebc09157ecdaa091c702f
hwmon: (adt7475) Potential error pointer dereferences

The adt7475_update_device() function returns error pointers.  The
problem is that in show_pwmfreq() we dereference it before the check.
And then in pwm_use_point2_pwm_at_crit_show() there isn't a check at
all.  I don't know if it's required, but it silences a static checker
warning and it's doesn't hurt anything to check.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/adt7475.c