]> git.baikalelectronics.ru Git - kernel.git/commit
media: dmxdev: change the check for problems allocing secfeed
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 9 Jun 2021 12:43:16 +0000 (14:43 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 9 Jun 2021 12:45:20 +0000 (14:45 +0200)
commit962a79618faad8cceae855a417320f3314fdec93
treeef5b3614102f52237988f0c3582e9e444f8d8fcb
parentd0fadeda9749ea23ef6c01caad302861e837928d
media: dmxdev: change the check for problems allocing secfeed

While the logic there is right, it tricks static check analyzers,
like smatch:

drivers/media/dvb-core/dmxdev.c:729 dvb_dmxdev_filter_start() error: we previously assumed '*secfeed' could be null (see line 719)

Because the implementation of the filter itself is made via
a callback, with its real implementation at the
dvbdmx_allocate_section_feed() inside dvb_demux.c.

So, change the check logic to make it clear that the function
will not try to use *secfeed == NULL.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/dvb-core/dmxdev.c