]> git.baikalelectronics.ru Git - kernel.git/commit
net/fec: fec_reset_phy() does not need to always succeed
authorShawn Guo <shawn.guo@linaro.org>
Fri, 23 Sep 2011 02:12:46 +0000 (02:12 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Sep 2011 17:55:25 +0000 (13:55 -0400)
commit9510d9c50bbcb6deb9c3e58e1177349f99a856e6
tree24ea8257f0c80308ac57e016c86437cfdc6b285d
parentf399117b0e0fa883160aacf8c72cd4d1ee9292d7
net/fec: fec_reset_phy() does not need to always succeed

FEC can work without a phy reset on some platforms, which means not
very platform necessarily have a phy-reset gpio encoded in device tree.
Even on the platforms that have the gpio, FEC can work without
resetting phy for some cases, e.g. boot loader has done that.

So it makes more sense to have the phy-reset-gpio request failure as
a debug message rather than a warning, and get fec_reset_phy() return
void since the caller does not check the return anyway.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec.c