]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "pinctrl: freescale: imx: Use 'devm_of_iomap()' to avoid a resource leak in...
authorHaibo Chen <haibo.chen@nxp.com>
Tue, 9 Jun 2020 03:27:03 +0000 (11:27 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 20 Jun 2020 20:04:39 +0000 (22:04 +0200)
commit94ebdd99956d56100f6fe9267e21287f93c5835e
tree0de020ae55f9ba49806b7ef9ed61a372b469be1a
parente635a9f2f678f8f5c1c8dbbd27085d9a618a6e06
Revert "pinctrl: freescale: imx: Use 'devm_of_iomap()' to avoid a resource leak in case of error in 'imx_pinctrl_probe()'"

This reverts commit f3a76b52553c3a3d9ae83371eb6bf590c7f35d3e.

After commit eefd732c06b7 ("pinctrl: freescale: imx: add shared
input select reg support"). i.MX7D has two iomux controllers
iomuxc and iomuxc-lpsr which share select_input register for
daisy chain settings.
If use 'devm_of_iomap()', when probe the iomuxc-lpsr, will call
devm_request_mem_region() for the region <0x30330000-0x3033ffff>
for the first time. Then, next time when probe the iomuxc, API
devm_platform_ioremap_resource() will also use the API
devm_request_mem_region() for the share region <0x30330000-0x3033ffff>
again, then cause issue, log like below:

[    0.179561] imx7d-pinctrl 302c0000.iomuxc-lpsr: initialized IMX pinctrl driver
[    0.191742] imx7d-pinctrl 30330000.pinctrl: can't request region for resource [mem 0x30330000-0x3033ffff]
[    0.191842] imx7d-pinctrl: probe of 30330000.pinctrl failed with error -16

Fixes: f3a76b52553c ("pinctrl: freescale: imx: Use 'devm_of_iomap()' to avoid a resource leak in case of error in 'imx_pinctrl_probe()'")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Link: https://lore.kernel.org/r/1591673223-1680-1-git-send-email-haibo.chen@nxp.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/freescale/pinctrl-imx.c