]> git.baikalelectronics.ru Git - kernel.git/commit
ipv6: release dst in ping_v6_sendmsg
authorDave Jones <davej@codemonkey.org.uk>
Fri, 2 Sep 2016 18:39:50 +0000 (14:39 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 6 Sep 2016 19:54:17 +0000 (12:54 -0700)
commit9487e0c3debf31b8581e26f8aff45aec96f55b79
treec910de1f10013bbc12295c279c727e5e39099ba5
parent0183769e1b6b026b26383a8621e6e7b55821a405
ipv6: release dst in ping_v6_sendmsg

Neither the failure or success paths of ping_v6_sendmsg release
the dst it acquires.  This leads to a flood of warnings from
"net/core/dst.c:288 dst_release" on older kernels that
don't have 012bb6bf5c965547bd647b70169d4f834a924dcf backported.

That patch optimistically hoped this had been fixed post 3.10, but
it seems at least one case wasn't, where I've seen this triggered
a lot from machines doing unprivileged icmp sockets.

Cc: Martin Lau <kafai@fb.com>
Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ping.c