]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/dp: Fix LTTPR vswing/pre-emp setting in non-transparent mode
authorImre Deak <imre.deak@intel.com>
Tue, 29 Dec 2020 17:22:01 +0000 (19:22 +0200)
committerJani Nikula <jani.nikula@intel.com>
Tue, 2 Feb 2021 15:31:37 +0000 (17:31 +0200)
commit943faaec292657175b10b8c762cf5d55a4ec60f8
tree67b0068c292e4b9137d81aa47a52f726553b1cf4
parent9f8fabc64e2838130ad15b15a97b82f112a3ac85
drm/i915/dp: Fix LTTPR vswing/pre-emp setting in non-transparent mode

The DP PHY vswing/pre-emphasis level programming the driver does is
related to the DPTX -> first LTTPR link segment only. Accordingly it
should be only programmed when link training the first LTTPR and kept
as-is when training subsequent LTTPRs and the DPRX. For these latter
PHYs the vs/pe levels will be set in response to writing the
DP_TRAINING_LANEx_SET_PHY_REPEATERy DPCD registers (by an upstream LTTPR
TX PHY snooping this write access of its downstream LTTPR/DPRX RX PHY).
The above is also described in DP Standard v2.0 under 3.6.6.1.

While at it simplify and add the LTTPR that is link trained to the debug
message in intel_dp_set_signal_levels().

Fixes: 2c148ab6e6fa ("drm/i915: Switch to LTTPR non-transparent mode link training")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201229172201.4155327-2-imre.deak@intel.com
(cherry picked from commit 67fba3f1c73b83569d171ae1fa463a537bbfe0a8)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_dp.c
drivers/gpu/drm/i915/display/intel_dp_link_training.c
drivers/gpu/drm/i915/display/intel_dp_link_training.h