]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: usb-audio: Clean up endpoint setups at PCM prepare
authorTakashi Iwai <tiwai@suse.de>
Thu, 1 Sep 2022 13:08:31 +0000 (15:08 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 1 Sep 2022 13:09:32 +0000 (15:09 +0200)
commit94071cb8d2687fa55ff9900caa9ab505d00b2d97
treeb0129f4830bd8aac5f22789392fea57576dcc887
parentdcea6ebbb66872a11aed8d0e940607d86fab7592
ALSA: usb-audio: Clean up endpoint setups at PCM prepare

This patch cleans up the superfluous checks and calls for setting up
the endpoints at PCM prepare callback:

- Drop stop_endpoints() and sync_pending_stops() calls; the stream is
  guaranteed to have been already stopped and synced at each PCM
  prepare call by ALSA PCM core

- Call snd_usb_endpoint_prepare() unconditionally;
  the check for endpoint->need_setup is done in
  snd_pcm_hw_endpoint_prepare() itself

- Apply snd_usb_set_format_quirk() only when the endpoint is actually
  set up (i.e. the return code from snd_usb_endpoint_prepare() > 0)

- Move a few lines back into snd_usb_pcm_prepare();
  it's even easier to follow than a small useless function

Link: https://lore.kernel.org/r/20220901130831.6136-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/pcm.c