]> git.baikalelectronics.ru Git - kernel.git/commit
drm: WARN when removing unallocated node
authorBen Widawsky <benjamin.widawsky@intel.com>
Wed, 14 Aug 2013 01:09:08 +0000 (18:09 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 22 Aug 2013 11:31:46 +0000 (13:31 +0200)
commit937464c0821cbd9b1750820885e00026ceb129eb
treeee753ed1dd51a46bf15d31ae9e691ff0e5a7e3e6
parentc5ea1e5daf2b1d9aab064f493c000b09bbe6266e
drm: WARN when removing unallocated node

The conditional is usually a recoverable driver bug, and so WARNing, and
preventing the drm_mm code from doing potential damage (BUG) is
desirable.

This issue was hit and fixed twice while developing the i915 multiple
address space code. The first fix is the patch just before this, and is
hit on an not frequently occuring error path. Another was fixed during
patch iteration, so it's hard to see from the patch:

commit 4fc54d76af2e404493256fe0df93375119ea2355
Author: Ben Widawsky <ben@bwidawsk.net>
Date:   Fri Jul 5 14:41:06 2013 -0700

    drm/i915: Embed drm_mm_node in i915 gem obj

From the intel-gfx mailing list, we discussed this:
References: <20130705191235.GA3057@bwidawsk.net>

Cc: Dave Airlie <airlied@redhat.com>
CC: <dri-devel@lists.freedesktop.org>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Acked-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_mm.c