]> git.baikalelectronics.ru Git - kernel.git/commit
hexdump: fix ascii column for the tail of a dump
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 12 Feb 2015 23:02:24 +0000 (15:02 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 13 Feb 2015 02:54:14 +0000 (18:54 -0800)
commit92fe7e05c4be41981b74eb2b08bc995ad04bceca
tree647a4637c3e1202b259dd36bb49586a411ce8dc7
parentb0a414e351cc05a1cdfa81bbc6ca2b808b9fa468
hexdump: fix ascii column for the tail of a dump

In the current implementation we have a floating ascii column in the tail
of the dump.

For example, for row size equal to 16 the ascii column as in following
table

group size \ length 8 12 16
1 50 50 50
2 22 32 42
4 20 29 38
8 19 - 36

This patch makes it the same independently of amount of bytes dumped.

The change is safe since all current users, which use ASCII part of the
dump, rely on the group size equal to 1.  The patch doesn't change
behaviour for such group size (see the table above).

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
lib/hexdump.c