]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/64s: Fix crashes when toggling entry flush barrier
authorMichael Ellerman <mpe@ellerman.id.au>
Thu, 6 May 2021 04:49:59 +0000 (14:49 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 14 May 2021 07:27:36 +0000 (17:27 +1000)
commit9259795a94c578b232817f369c9a8c50132d00ca
treee2bffb1ba73e468e69b6d034fd8372cb4455ba53
parent0296392300d9d5396331fd2069e782f6c2fd90d9
powerpc/64s: Fix crashes when toggling entry flush barrier

The entry flush mitigation can be enabled/disabled at runtime via a
debugfs file (entry_flush), which causes the kernel to patch itself to
enable/disable the relevant mitigations.

However depending on which mitigation we're using, it may not be safe to
do that patching while other CPUs are active. For example the following
crash:

  sleeper[15639]: segfault (11) at c000000000004c20 nip c000000000004c20 lr c000000000004c20

Shows that we returned to userspace with a corrupted LR that points into
the kernel, due to executing the partially patched call to the fallback
entry flush (ie. we missed the LR restore).

Fix it by doing the patching under stop machine. The CPUs that aren't
doing the patching will be spinning in the core of the stop machine
logic. That is currently sufficient for our purposes, because none of
the patching we do is to that code or anywhere in the vicinity.

Fixes: 6d3f0007d161 ("powerpc/64s: flush L1D on kernel entry")
Cc: stable@vger.kernel.org # v5.10+
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210506044959.1298123-2-mpe@ellerman.id.au
arch/powerpc/lib/feature-fixups.c