]> git.baikalelectronics.ru Git - kernel.git/commit
video: fbdev: neofb: Fix the check of 'var->pixclock'
authorZheyu Ma <zheyuma97@gmail.com>
Mon, 4 Apr 2022 08:47:18 +0000 (16:47 +0800)
committerHelge Deller <deller@gmx.de>
Mon, 11 Apr 2022 06:23:49 +0000 (08:23 +0200)
commit92385c44107e9a634402b789d3ee3c088f8c2d98
treebe19597c03ac04ff666cbd2ab91d17fbe37aff6c
parentb84b320126cce9dacfc8f752f3ab7c49745970c2
video: fbdev: neofb: Fix the check of 'var->pixclock'

The previous check against 'var->pixclock' doesn't return -EINVAL when
it equals zero, but the driver uses it again, causing the divide error.

Fix this by returning when 'var->pixclock' is zero.

The following log reveals it:
 divide error: 0000 [#1] PREEMPT SMP KASAN PTI
 RIP: 0010:neofb_set_par+0x190f/0x49a0
 Call Trace:
  <TASK>
  fb_set_var+0x604/0xeb0
  do_fb_ioctl+0x234/0x670
  fb_ioctl+0xdd/0x130
  do_syscall_64+0x3b/0x90

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/neofb.c