]> git.baikalelectronics.ru Git - kernel.git/commit
firewire: ohci: fix TI TSB82AA2 regression since 2.6.35
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Sun, 17 Oct 2010 12:09:12 +0000 (14:09 +0200)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Sun, 17 Oct 2010 12:09:12 +0000 (14:09 +0200)
commit91ee31a23d40719b8cc34c2bd32997febd11997b
tree0a64674f2fa51883c66e96c743dd4c4e86d98a49
parent13fcf89ab4ee9182a36c424ebf256a67c0661457
firewire: ohci: fix TI TSB82AA2 regression since 2.6.35

Revert commit f085bf34121d91fd3916681c0a36c67290ec5a45
"firewire: ohci: fix up configuration of TI chips".
It caused massive slow-down and data corruption with a TSB82AA2 based
StarTech EC1394B2 ExpressCard and FireWire 800 harddisks.

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/657081
http://thread.gmane.org/gmane.linux.kernel.firewire.user/4013

The fact that some card EEPROMs do not program these enhancements may be
related to TSB81BA3 phy chip errata, if not to bugs of TSB82AA2 itself.
We could re-add these configuration steps, but only conditional on a
whitelist of cards on which these enhancements bring a proven positive
effect.

Reported-and-tested-by: Eric Shattow <lucent@gmail.com>
Cc: Clemens Ladisch <clemens@ladisch.de>
Cc: <stable@kernel.org> 2.6.35
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/ohci.c
drivers/firewire/ohci.h