]> git.baikalelectronics.ru Git - kernel.git/commit
HID: logitech-hidpp: initialize level variable
authorTom Rix <trix@redhat.com>
Fri, 7 May 2021 19:18:19 +0000 (12:18 -0700)
committerJiri Kosina <jkosina@suse.cz>
Thu, 27 May 2021 13:40:34 +0000 (15:40 +0200)
commit91e204613c69f8f53fecc3b9f809186ca07cb241
treee660ef31d1c8ca2210d3b79ca53c5cff31feb25b
parent821d39607e0a2467626213f2919d0ec1d8f591ba
HID: logitech-hidpp: initialize level variable

Static analysis reports this representative problem

hid-logitech-hidpp.c:1356:23: warning: Assigned value is
  garbage or undefined
        hidpp->battery.level = level;
                             ^ ~~~~~

In some cases, 'level' is never set in hidpp20_battery_map_status_voltage()
Since level is not available on all hw, initialize level to unknown.

Fixes: 420b14beecac ("hid-logitech-hidpp: read battery voltage from newer devices")
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Filipe LaĆ­ns <lains@riseup.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-logitech-hidpp.c