]> git.baikalelectronics.ru Git - kernel.git/commit
platform/x86/intel: pmc/core: change pmc_lpm_modes to static
authorTom Rix <trix@redhat.com>
Sat, 23 Apr 2022 12:30:48 +0000 (08:30 -0400)
committerHans de Goede <hdegoede@redhat.com>
Wed, 27 Apr 2022 14:55:54 +0000 (16:55 +0200)
commit9194466a6498368f73f574fc365eac7bda46557d
tree46db60bb4eb7ef8cc669309fc74a6f88d5e5cbb3
parent3e15403a4024b0b8e2bc1183fc26cb1843e480d4
platform/x86/intel: pmc/core: change pmc_lpm_modes to static

Sparse reports this issue
core.c: note: in included file:
core.h:239:12: warning: symbol 'pmc_lpm_modes' was not declared. Should it be static?

Global variables should not be defined in headers.  This only works
because core.h is only included by core.c. Single file use
variables should be static, so change its storage-class specifier
to static.

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: David E. Box <david.e.box@linux.intel.com>
Link: https://lore.kernel.org/r/20220423123048.591405-1-trix@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/intel/pmc/core.h