]> git.baikalelectronics.ru Git - kernel.git/commit
net: phy: fix less than zero comparison with unsigned variable val
authorColin Ian King <colin.king@canonical.com>
Thu, 7 May 2020 14:34:30 +0000 (15:34 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 May 2020 01:07:40 +0000 (18:07 -0700)
commit9189a91f330f3a7651cfaaa0478f3ec32f479e68
tree28d5793e21767a2833da06910ec00d252d591b14
parentd52fe7293e072c22d9e11754e9b4b518f322aba7
net: phy: fix less than zero comparison with unsigned variable val

The unsigned variable val is being checked for an error by checking
if it is less than zero. This can never occur because val is unsigned.
Fix this by making val a plain int.

Addresses-Coverity: ("Unsigned compared against zero")
Fixes: 2c1e937a7727 ("ethtool: provide UAPI for PHY master/slave configuration.")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy_device.c