]> git.baikalelectronics.ru Git - kernel.git/commit
vsock: prevent unnecessary refcnt inc for nonblocking connect
authorEiichi Tsukata <eiichi.tsukata@nutanix.com>
Tue, 9 Nov 2021 00:15:02 +0000 (00:15 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 10 Nov 2021 14:36:11 +0000 (14:36 +0000)
commit91143879e33e7498719775ba491fa427d439961a
treeea5e3eb16b2a08584569f0c61e9e5ddac06fb301
parent7eefe2c12395336e1430ae3f580fad2334530d1b
vsock: prevent unnecessary refcnt inc for nonblocking connect

Currently vosck_connect() increments sock refcount for nonblocking
socket each time it's called, which can lead to memory leak if
it's called multiple times because connect timeout function decrements
sock refcount only once.

Fixes it by making vsock_connect() return -EALREADY immediately when
sock state is already SS_CONNECTING.

Fixes: e9d736dd26b5 ("VSOCK: Introduce VM Sockets")
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/vmw_vsock/af_vsock.c