]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: target: iscsi: Avoid in_interrupt() usage in iscsit_check_session_usage_count()
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Sun, 20 Dec 2020 20:36:34 +0000 (21:36 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 23 Jan 2021 01:25:25 +0000 (20:25 -0500)
commit90f62ff828ca36846bfa71d03131bec3d03eb954
tree7a64f7b472e603c4edfd45652a466f27598f0624
parentc9777b653402079b2f2ac8a4c64bcbe50f10d1e5
scsi: target: iscsi: Avoid in_interrupt() usage in iscsit_check_session_usage_count()

iscsit_check_session_usage_count() uses in_interrupt() to find out if it is
safe to invoke wait_for_completion().

The usage of in_interrupt() in drivers is phased out and Linus clearly
requested that code which changes behaviour depending on context should
either be separated or the context be conveyed in an argument passed by the
caller, which usually knows the context.

There is only one caller of iscsit_check_session_usage_count() which
already has an argument indicating if it is safe to sleep.

Extend iscsit_check_session_usage_count() by an argument indicating if it
may sleep.

Link: https://lore.kernel.org/r/20201220203638.43615-3-bigeasy@linutronix.de
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/iscsi/iscsi_target.c
drivers/target/iscsi/iscsi_target_util.c
drivers/target/iscsi/iscsi_target_util.h