]> git.baikalelectronics.ru Git - kernel.git/commit
drivers/mailbox/omap: make mbox->irq signed for error handling
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 23 Jan 2014 23:53:45 +0000 (15:53 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 24 Jan 2014 00:36:53 +0000 (16:36 -0800)
commit90895a7be8ff0882ecb541869593c27e3730a6a1
tree8eeb86f4a8af5b267876bf749d959d154ee1b68c
parentdf48ec42ec5eb9a37605a140a71385c8f5901185
drivers/mailbox/omap: make mbox->irq signed for error handling

There is a bug in omap2_mbox_probe() where we try do:

mbox->irq = platform_get_irq(pdev, info->irq_id);
if (mbox->irq < 0) {

The problem is that mbox->irq is unsigned so the error handling doesn't
work.  I've changed it to a signed integer.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Suman Anna <s-anna@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Omar Ramirez Luna <omar.ramirez@copitl.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/mailbox/omap-mbox.h