]> git.baikalelectronics.ru Git - kernel.git/commit
tuntap: correctly wake up process during uninit
authorJason Wang <jasowang@redhat.com>
Thu, 19 May 2016 05:36:51 +0000 (13:36 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 May 2016 23:28:37 +0000 (19:28 -0400)
commit9061f5c5a4d63034a8270f7072c63cf53d044347
treec0e712a1e95d2413004aeffd14ac45627b287c92
parentf26c49a81c125a8fa452a3fd2c4d3a9f69edcca4
tuntap: correctly wake up process during uninit

We used to check dev->reg_state against NETREG_REGISTERED after each
time we are woke up. But after commit 362175c56988 ("net-tun:
restructure tun_do_read for better sleep/wakeup efficiency"), it uses
skb_recv_datagram() which does not check dev->reg_state. This will
result if we delete a tun/tap device after a process is blocked in the
reading. The device will wait for the reference count which was held
by that process for ever.

Fixes this by using RCV_SHUTDOWN which will be checked during
sk_recv_datagram() before trying to wake up the process during uninit.

Fixes: 362175c56988 ("net-tun: restructure tun_do_read for better
sleep/wakeup efficiency")
Cc: Eric Dumazet <edumazet@google.com>
Cc: Xi Wang <xii@google.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tun.c