]> git.baikalelectronics.ru Git - kernel.git/commit
drm/imx: notify drm core before sending event during crtc disable
authorRobert Beckett <bob.beckett@collabora.com>
Tue, 25 Jun 2019 17:59:13 +0000 (18:59 +0100)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Thu, 4 Jul 2019 10:21:25 +0000 (12:21 +0200)
commit9056cd6418072984af967b14068a74bbfdcc1cc2
tree46a6459c329bd5cd87c28d7ce50d886b9db038a0
parenta3643cb88e5c6bc01d219dfab095666d67d43f00
drm/imx: notify drm core before sending event during crtc disable

Notify drm core before sending pending events during crtc disable.
This fixes the first event after disable having an old stale timestamp
by having drm_crtc_vblank_off update the timestamp to now.

This was seen while debugging weston log message:
Warning: computed repaint delay is insane: -8212 msec

This occurred due to:
1. driver starts up
2. fbcon comes along and restores fbdev, enabling vblank
3. vblank_disable_fn fires via timer disabling vblank, keeping vblank
seq number and time set at current value
(some time later)
4. weston starts and does a modeset
5. atomic commit disables crtc while it does the modeset
6. ipu_crtc_atomic_disable sends vblank with old seq number and time

Fixes: 5bc40919d8b4 ("drm/imx: fix crtc vblank state regression")
Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
drivers/gpu/drm/imx/ipuv3-crtc.c