]> git.baikalelectronics.ru Git - kernel.git/commit
nvmet-rdma: Fix a possible uninitialized variable dereference
authorSagi Grimberg <sagi@grimberg.me>
Thu, 9 Mar 2017 11:45:52 +0000 (13:45 +0200)
committerJens Axboe <axboe@fb.com>
Tue, 4 Apr 2017 15:48:23 +0000 (09:48 -0600)
commit905306bc01211887763dbc8b1cd78189742cf2d4
tree87682095b8ae53e0397a9110d67e44666eb19c02
parent157106896c35e767e824f573a5874cc626a2883b
nvmet-rdma: Fix a possible uninitialized variable dereference

When handling a new recv command, we grab a new rsp resource and
check for the queue state being live. In case the queue is not in
live state, we simply restore the rsp back to the free list. However
in this flow we didn't set rsp->queue yet, so we cannot dereference it.

Instead, make sure to initialize rsp->queue (and other rsp members)
as soon as possible so we won't reference uninitialized variables.

Reported-by: Yi Zhang <yizhan@redhat.com>
Reported-by: Raju Rangoju <rajur@chelsio.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Raju Rangoju <rajur@chelsio.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/nvme/target/rdma.c