]> git.baikalelectronics.ru Git - kernel.git/commit
net: dccp: fix sign bug
authorKulikov Vasiliy <segooon@gmail.com>
Sat, 17 Jul 2010 05:21:00 +0000 (05:21 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 18 Jul 2010 22:07:14 +0000 (15:07 -0700)
commit9032ee89921850841dd1fe38c7d9527bbc2ec57f
tree81e564d8f12fe7c8a7b9819572a1f1787c1d224e
parentc27fc4ef6f1bb12bd52d56630d84e74a1066ab91
net: dccp: fix sign bug

'gap' is unsigned, so this code is wrong:

    gap = -new_head;
    ...
    if (gap > 0) { ... }

Make 'gap' signed.

The semantic patch that finds this problem (many false-positive results):
(http://coccinelle.lip6.fr/)

// <smpl>
@ r1 @
identifier f;
@@
int f(...) { ... }

@@
identifier r1.f;
type T;
unsigned T x;
@@

*x = f(...)
 ...
*x > 0

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dccp/ackvec.c