]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "qlcnic: Avoid potential NULL pointer dereference"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:56:51 +0000 (13:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 15:33:26 +0000 (17:33 +0200)
commit9014df8d2da42ebffab929ec8428a2ebeff9e0e1
tree58c1944f31877304b4cfbe4cc2bfb7e3560b6621
parent451d09a2a809972db32bbdc0fac894bf8bff50d3
Revert "qlcnic: Avoid potential NULL pointer dereference"

This reverts commit 313de0f2843e0677a129826faec1421af2a4f1c9.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

This commit does not properly detect if an error happens because the
logic after this loop will not detect that there was a failed
allocation.

Cc: Aditya Pakki <pakki001@umn.edu>
Cc: David S. Miller <davem@davemloft.net>
Fixes: 313de0f2843e ("qlcnic: Avoid potential NULL pointer dereference")
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-25-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c