]> git.baikalelectronics.ru Git - kernel.git/commit
hwmon: (w83793) Fix NULL pointer dereference by removing unnecessary structure field
authorNadezda Lutovinova <lutovinova@ispras.ru>
Tue, 21 Sep 2021 15:51:53 +0000 (18:51 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Oct 2021 13:42:30 +0000 (15:42 +0200)
commit8f9f79d87aead61e644b68db3f6bd7becc276ade
treeea782e1181ade797a72695b2d0d39048d9ca2cdb
parent4e1fa05842d496912482889c91f2208fea2cb52c
hwmon: (w83793) Fix NULL pointer dereference by removing unnecessary structure field

commit dd4d747ef05addab887dc8ff0d6ab9860bbcd783 upstream.

If driver read tmp value sufficient for
(tmp & 0x08) && (!(tmp & 0x80)) && ((tmp & 0x7) == ((tmp >> 4) & 0x7))
from device then Null pointer dereference occurs.
(It is possible if tmp = 0b0xyz1xyz, where same literals mean same numbers)
Also lm75[] does not serve a purpose anymore after switching to
devm_i2c_new_dummy_device() in w83791d_detect_subclients().

The patch fixes possible NULL pointer dereference by removing lm75[].

Found by Linux Driver Verification project (linuxtesting.org).

Cc: stable@vger.kernel.org
Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
Link: https://lore.kernel.org/r/20210921155153.28098-3-lutovinova@ispras.ru
[groeck: Dropped unnecessary continuation lines, fixed multi-line alignments]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwmon/w83793.c