]> git.baikalelectronics.ru Git - kernel.git/commit
net: ethtool: not call vzalloc for zero sized memory request
authorLi RongQing <lirongqing@baidu.com>
Fri, 29 Mar 2019 01:18:02 +0000 (09:18 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 29 Mar 2019 20:41:55 +0000 (13:41 -0700)
commit8f73dbbfc81b261a2f8fd8bf2aff21461ad0ea0d
treec09e7bdb15135334481111a1ea485d07cada840c
parent594a61ad5b6244b7ac74d00a34af01f240e1f212
net: ethtool: not call vzalloc for zero sized memory request

NULL or ZERO_SIZE_PTR will be returned for zero sized memory
request, and derefencing them will lead to a segfault

so it is unnecessory to call vzalloc for zero sized memory
request and not call functions which maybe derefence the
NULL allocated memory

this also fixes a possible memory leak if phy_ethtool_get_stats
returns error, memory should be freed before exit

Signed-off-by: Li RongQing <lirongqing@baidu.com>
Reviewed-by: Wang Li <wangli39@baidu.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/ethtool.c