]> git.baikalelectronics.ru Git - kernel.git/commit
video: fbdev: arkfb: Error out if 'pixclock' equals zero
authorZheyu Ma <zheyuma97@gmail.com>
Mon, 4 Apr 2022 08:47:22 +0000 (16:47 +0800)
committerHelge Deller <deller@gmx.de>
Mon, 11 Apr 2022 06:23:50 +0000 (08:23 +0200)
commit8f577de38d76690321dc6d769a41e3d7b3199c1e
treeed045c858289dc74685f48bb6db01cef197b2875
parentfd2310d4a57b21c8cf3bdcdba9023036a745d947
video: fbdev: arkfb: Error out if 'pixclock' equals zero

The userspace program could pass any values to the driver through
ioctl() interface. If the driver doesn't check the value of 'pixclock',
it may cause divide error.

Fix this by checking whether 'pixclock' is zero.

The following log reveals it:
 divide error: 0000 [#1] PREEMPT SMP KASAN PTI
 RIP: 0010:arkfb_set_par+0x10fc/0x24f0
 Call Trace:
  <TASK>
  fb_set_var+0x604/0xeb0
  do_fb_ioctl+0x234/0x670
  fb_ioctl+0xdd/0x130
  do_syscall_64+0x3b/0x90

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/arkfb.c