]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"
authorMicky Ching <micky_ching@realsil.com.cn>
Tue, 29 Apr 2014 01:54:54 +0000 (09:54 +0800)
committerLee Jones <lee.jones@linaro.org>
Thu, 8 May 2014 07:44:50 +0000 (08:44 +0100)
commit8f4daed962959114a299c05211d7e0a06aef2540
treee6a8a40298933d61b485a1969f1dc3a837238c17
parent5c213d7f9e4fe05999e1ce511c99588560553254
mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

This reverts commit 6f69cbcea278713a9c2670cdbafa2cd601105411.

commit <mmc: rtsx: add support for pre_req and post_req> did use
mutex_unlock() in tasklet, but mutex_unlock() can't be used in
tasklet(atomic context). The driver needs to use mutex to avoid
concurrency, so we can't use tasklet here, the patch need to be
removed.

The spinlock host->lock and pcr->lock may deadlock, one way to solve
the deadlock is remove host->lock in sd_isr_done_transfer(), but if
using workqueue the we can avoid using the spinlock and also avoid
the problem.

Signed-off-by: Micky Ching <micky_ching@realsil.com.cn>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/rtsx_pcr.c
drivers/mmc/host/rtsx_pci_sdmmc.c
include/linux/mfd/rtsx_common.h
include/linux/mfd/rtsx_pci.h