]> git.baikalelectronics.ru Git - kernel.git/commit
net/fec: fix fec1 check in fec_enet_mii_init()
authorShawn Guo <shawn.guo@linaro.org>
Fri, 23 Sep 2011 02:12:47 +0000 (02:12 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Sep 2011 17:55:26 +0000 (13:55 -0400)
commit8f335d262471baf41401428521880a2ce68cb696
treebed57a3190f377d9aa5846ab85a949ff2a321a76
parent1e82a900386a27ca8eb94c0dd129f1c87a120394
net/fec: fix fec1 check in fec_enet_mii_init()

In function fec_enet_mii_init(), it uses non-zero pdev->id as part
of the condition to check the second fec instance (fec1).  This works
before the driver supports device tree probe.  But in case of device
tree probe, pdev->id is -1 which is also non-zero, so the logic becomes
broken when device tree probe gets supported.

The patch change the logic to check "pdev->id > 0" as the part of the
condition for identifying fec1.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec.c