]> git.baikalelectronics.ru Git - kernel.git/commit
ravb: Add missing free_irq() calls to ravb_close()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 17 May 2016 09:05:34 +0000 (11:05 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 May 2016 16:26:56 +0000 (12:26 -0400)
commit8ecae7bdba3ae6ed230810dd71fcbb08aef39b66
tree6978462940fd72e2c06a61cab6bca938c9bc3c10
parentb99cf4dbca3644d40565ea3e1baabe3947f7953e
ravb: Add missing free_irq() calls to ravb_close()

When reopening the network device on ra7795/salvator-x, e.g. after a
DHCP timeout:

    IP-Config: Reopening network devices...
    genirq: Flags mismatch irq 139. 00000000 (eth0:ch0:rx_be) vs. 00000000 (ravb e6800000.ethernet eth0: cannot request IRQ eth0:ch0:rx_be
    IP-Config: Failed to open eth0
    IP-Config: No network devices available

The "mismatch" is due to requesting an IRQ that is already in use,
while IRQF_PROBE_SHARED wasn't set.

However, the real cause is that ravb_close() doesn't release any of the
R-Car Gen3-specific secondary IRQs.

Add the missing free_irq() calls to fix this.

Fixes: 6a7b7edee83b068e ("ravb: Add dma queue interrupt support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/ravb_main.c