]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: wcd-mbhc-v2: remove always-true condition
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mon, 22 Aug 2022 18:42:36 +0000 (20:42 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 31 Aug 2022 11:13:01 +0000 (12:13 +0100)
commit8e3a833e2e320d713919623b714d46893f8a3f43
tree57e201c54e20a2bf973ef2a8362716b3eef4f401
parent697ddff79b36dd07e185b792e68bda3c3fd60918
ASoC: wcd-mbhc-v2: remove always-true condition

cppcheck warning:

'cross_conn<0' is always true [knownConditionTrueFalse]
   } else if (cross_conn < 0) /* Error */
                         ^
'!cross_conn' is not redundant
   } else if (!cross_conn) { /* no cross connection */
              ^
is always true
   } else if (cross_conn < 0) /* Error */
                         ^

sound/soc/codecs/wcd-mbhc-v2.c:1192:26: style: Condition
sound/soc/codecs/wcd-mbhc-v2.c:1188:15: note: Assuming that condition
sound/soc/codecs/wcd-mbhc-v2.c:1192:26: note: Condition 'cross_conn<0'
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Chao Song <chao.song@intel.com>
Link: https://lore.kernel.org/r/20220822184239.169757-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wcd-mbhc-v2.c