]> git.baikalelectronics.ru Git - kernel.git/commit
drm/msm: Fix potential Oops in a6xx_gmu_rpmh_init()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 4 Oct 2021 13:45:30 +0000 (16:45 +0300)
committerRob Clark <robdclark@chromium.org>
Fri, 15 Oct 2021 20:26:34 +0000 (13:26 -0700)
commit8e2011d2a78412839391a5c2845d2bebb49eb6f1
tree3a1f93dc5f2962cc4974b4afa7bf71cb734885fe
parentff174a4c46ae1c4ab01d7da55e84468d9c3072e7
drm/msm: Fix potential Oops in a6xx_gmu_rpmh_init()

There are two problems here:
1) The "seqptr" is used uninitalized when we free it at the end.
2) The a6xx_gmu_get_mmio() function returns error pointers.  It never
   returns true.

Fixes: c5f1bacb7c5e ("drm/msm/a6xx: use AOP-initialized PDC for a650")
Fixes: b43ca19954ae ("drm/msm/a6xx: Fix PDC register overlap")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20211004134530.GB11689@kili
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/adreno/a6xx_gmu.c